AliIbnBotir commented on code in PR #45275:
URL: https://github.com/apache/superset/pull/45275#discussion_r4279329644
##########
superset-frontend/src/components/Chart/ChartRenderer.tsx:
##########
@@ -239,6 +242,17 @@ function ChartRendererComponent({
[source, suppressContextMenu],
);
+ // Tells plugins where they render, e.g. to allow editing only in Explore.
+ // Standalone Explore serves embedded charts and report screenshots.
+ const appSection = useMemo(() => {
+ if (source === ChartSource.Dashboard) {
+ return AppSection.Dashboard;
Review Comment:
Kept embedded dashboards as Dashboard and clarified the description and code
comment. The chart is read-only on dashboards either way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
