AliIbnBotir opened a new pull request, #45275:
URL: https://github.com/apache/superset/pull/45275
### SUMMARY
`ChartRenderer` now passes `appSection` to `SuperChart`, so a chart plugin
can tell
where it is rendered:
- `AppSection.Explore` in Explore
- `AppSection.Dashboard` on a dashboard
- `AppSection.Embedded` in standalone Explore (`?standalone=`), which
embedded charts and report screenshots use
`ChartProps.appSection` already exists in `@superset-ui/core`, but
`ChartRenderer` never
set it, so plugins always received `undefined`. With it, a plugin can, for
example,
allow editing only in Explore.
This is needed by the Spreadsheet chart proposed in SIP #45265, but it is
generic and
useful on its own. No existing plugin changes behaviour, because none read
the prop today.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A (no visual change)
### TESTING INSTRUCTIONS
- `npm run test -- src/components/Chart/ChartRenderer.test.tsx`
- Three new tests check that `appSection` is `Explore`, `Dashboard`, or
`Embedded`
(standalone URL param) depending on where the chart renders.
### ADDITIONAL INFORMATION
- [x] Has associated issue: related to #45265
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
