mikebridge commented on PR #44999: URL: https://github.com/apache/superset/pull/44999#issuecomment-6181968276
@gabotorresruiz I ran the browser checks and found a gap in the standalone semantic Range chart in Explore: the generic no-results screen hid its manual input when the successful response contained no query results. Fixed in f658904c85eb6d94a36607ff23ece7c078719fbd, with a red-first regression through the real chart wrapper. - The standalone chart now renders its default Exact input, accepts a value and clears. The wrapper test also checks lower/upper inputs and their emitted predicates. - Native semantic bounds 5..7 filter the synthetic rows correctly; Clear All restores them, and Minimum/Maximum/Exact modes clear without validation errors. No semantic MIN/MAX discovery requests were sent. - The local SQLite slider still responds and applies, and empty/all-NULL SQL columns retain usable manual inputs. Focused tests passed (83 tests), as did hooks and frontend type checking. These browser checks used a numeric adaptation of the public #45103 stub with synthetic data through the real Superset extension/metadata/query paths. I did not run live Snowflake or the semantic SQL-name bigint/integer picker-alias cases; the stub's Arrow types are not evidence for those cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
