mikebridge commented on code in PR #44999:
URL: https://github.com/apache/superset/pull/44999#discussion_r4286500192
##########
superset-frontend/src/utils/semanticViewStructure.ts:
##########
@@ -53,7 +53,7 @@ export const mapSemanticTypeToGenericDataType = (
}
if (
- /(\b(u?int\d*)\b|\bfloat\d*\b|\bdouble\b|\bdecimal\d*\b|\bnumber\b)/.test(
+
/(\b(u?int\d*|integer|bigint|smallint|tinyint|numeric|real)\b|\bfloat\d*\b|\bdouble\b|\bdecimal\d*\b|\bnumber\b)/.test(
Review Comment:
Fixed in f14d312e71b89c8cac291217297bb990f0e4734c. Added `halffloat` to the
numeric mapper and the red-first case `preserves Arrow numeric dimension
halffloat in the shared column metadata`. I also checked local Arrow `str()`
outputs and covered signed/unsigned 8–64-bit integers, `float`, `double`, and
decimal32/64/128/256 with precision/scale in the same test matrix. Only
`halffloat` failed before the token change. The final focused run passed all
129 tests; hooks and frontend types passed.
##########
superset-frontend/src/filters/components/Range/RangeFilterPlugin.tsx:
##########
@@ -176,6 +177,23 @@ const validateRange = (
max,
});
+ if (values.some(value => value !== null && !Number.isFinite(value))) {
+ return { isValid: false, errorMessage: requiredError };
+ }
+
+ // Allow empty ranges if enableEmptyFilter is false
+ if (!enableEmptyFilter && inputMin === null && inputMax === null) {
Review Comment:
Added in f14d312e71b89c8cac291217297bb990f0e4734c: `SQL single-value mode
$mode validates cleared input with required=$required` covers all six
combinations of Minimum/Maximum/Exact and the required flag using a `3__table`
datasource. Optional clears emit `[null, null]` with no validation error;
required clears remain rejected. As a regression control, temporarily restoring
the old check order fails all three optional cases while the three required
cases still pass. No SQL validation behavior changed in this commit. The final
focused run passed 129 tests, plus hooks and frontend types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
