aminghadersohi commented on PR #45283: URL: https://github.com/apache/superset/pull/45283#issuecomment-6188667753
Commit 7de1b2c156d2d26f7b4c66c658345d305e4e0fe8 covers both stop-outcome cases: - If completion wins, the stop endpoint returns the existing non-stoppable response (HTTP 422, `Could not cancel query`) with the completed query payload. Async cancellation returns `False`, including when completion commits during cancellation. - If stopping wins, the guarded write refreshes the locked row and merges only the early-stop flag into its latest extra metadata, retaining a worker's concurrently committed cancel ID and progress text. SQL Lab applies the completed-query payload through its normal query-refresh action instead of marking the query stopped or showing a stop toast. An unsupported cancellation still shows the error toast. Regression evidence at starting head 3d14338e31b03a4b5ca191dfa7f21487a510eb2b, before production edits: - `test_stop_reports_concurrently_finished_query`: 12 failures → 12 passes. - `test_winning_stop_preserves_concurrently_committed_extra`: 2 failures and 2 passing controls → 4 passes. - `postStopQuery refreshes an already %s query without a toast`: 3 failures → 3 passes; the unsupported-stop toast control passes. Validation: - `pytest` over SQL execution, DAOs, Trino/Impala (including pending operations), base/SQLite engine specs, SQL Lab, SQL Lab commands and error-stacktrace tests: **3,169 passed, 2 skipped**. SQL Lab model tests: **28 passed**. `manual` and `llm_compliance` tests were excluded. - `npm test -- --maxWorkers=2 src/SqlLab/actions/sqlLab.test.ts src/SqlLab/reducers/sqlLab.test.ts src/SqlLab/components/QueryAutoRefresh/QueryAutoRefresh.test.tsx`: **140 passed, 1 skipped**. - `pre-commit run`, branch-file pre-commit checks and `pre-commit run mypy`: applicable hooks pass except frontend type-checking. Running `scripts/check-type.js` on the same two action files at the starting head and this commit produces the same 900 diagnostics (including missing package declaration outputs), with no added diagnostics. The Impala pending-operation test also asserts stage-only early intent, matching the caller-owned guarded transaction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
