aminghadersohi commented on PR #45283: URL: https://github.com/apache/superset/pull/45283#issuecomment-6189915690
**Acceptance: don't ship at ae40a754f3b05f1e25cb32d933ee57e733e84ae8.** Real Postgres SQL Lab Stop trials ended FAILED instead of STOPPED in **16/36 API** and **22/36 browser** cases across sync/async execution. The browser audit captured committed STOPPED → FAILED writes that also replaced the Stop end time; some HTTP-200 Stops left a Stopped screen paired with a FAILED row. Target INSERTs/CTAS rolled back correctly. Merge-base controls ended STOPPED in **18/18** cases. The legacy error-handler write and the guarded stop outcome need to agree on cancellation-triggered failures. The newer SQLExecutor Celery path passed **18/18** stop cases; already-finished Stop preserved SUCCESS/results in **24/24** API/browser cases, including the real 422 response without a stop/error toast. No branch changes pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
