EnxDev opened a new pull request, #45337:
URL: https://github.com/apache/superset/pull/45337

   ### SUMMARY
   
   The JSON column on the Action Logs page shows the raw payload as a single 
truncated line. Most of those payloads are nested (`rison`, `filters`, 
impression data), so reading one meant hovering for a tooltip with a wall of 
text.
   
   SQL Lab already solves this for result cells: a JSON object or array opens a 
modal with a collapsible tree and a Copy button. This PR reuses that same 
`JsonModal` (and the same `safeJsonObjectParse` check) in the Action Logs JSON 
column.
   
   - Values that parse as a JSON object or array render as a clickable, 
ellipsized cell that opens the tree modal.
   - Anything else falls back to the existing `Typography.Text` with the 
tooltip and hover copy icon, so nothing changes for plain strings or empty 
values.
   
   For JSON cells, the hover tooltip and inline copy icon are replaced by the 
modal and its Copy button.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   **Before**
   
   <!-- before.mp4 -->
   
   **After**
   
   <!-- after.mp4 -->
   
   ### TESTING INSTRUCTIONS
   
   1. Log in as an admin and open Settings > Action Log (`/actionlog/list`).
   2. Click a cell in the JSON column whose payload is an object, e.g. a 
`DatabaseRestApi.get_list` row.
   3. A "JSON" modal opens with a collapsible tree. Expand a nested key, then 
use Copy to grab the raw payload.
   4. Rows whose JSON value isn't a JSON object still show the old truncated 
text with tooltip.
   
   Unit tests: `npm run test -- src/pages/ActionLog`
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to