sadpandajoe commented on code in PR #45337:
URL: https://github.com/apache/superset/pull/45337#discussion_r4282232702
##########
superset-frontend/src/pages/ActionLog/index.tsx:
##########
@@ -48,6 +50,15 @@ export type ActionLogObject = {
const PAGE_SIZE = 25;
+const JsonCellTrigger = styled.div`
+ [data-test='span-modal-trigger'] {
Review Comment:
In production builds the babel `jsx-remove-data-test-id` plugin strips
`data-test` attributes, so this `[data-test='span-modal-trigger']` selector
won't match there. The ellipsis, nowrap and pointer cursor would then only
apply in dev/test, and a long JSON payload would render as clipped text with no
click affordance in the real Action Log. Would a class on the wrapper (e.g. a
`className` on the `JsonModal` trigger, or styling the cell container directly)
work here instead of relying on `data-test`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
