mikebridge commented on PR #45287:
URL: https://github.com/apache/superset/pull/45287#issuecomment-6199149255
Re CodeAnt's risk note on `json.loads`: addressed in b4f6d7048e. A
serialized configuration that is not a JSON object (malformed, an array or a
scalar) now raises `SemanticViewInvalidError` ("The view configuration must be
a JSON object."), before the provider lookup. The batch endpoint reports that
per view and carries on with the rest.
Before this change it didn't abort the request: the `JSONDecodeError` became
a generic per-view create failure through the `@transaction` handler. It also
can't arise from the batch API, whose schema loads `configuration` as a dict.
It can still arise from a direct command caller, so the error is now the right
one. New test: `test_create_semantic_view_malformed_configuration`, red first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
