aminghadersohi commented on code in PR #45287: URL: https://github.com/apache/superset/pull/45287#discussion_r4286776986
########## docs/docs/using-superset/semantic-layer-connections.mdx: ########## @@ -61,3 +61,9 @@ keeps dependent choices unavailable until that source is filled. Clearing an optional dependency can load choices for the empty state instead. Semantic views listed for an earlier dependency are discarded, and views cannot be added while dependent choices are loading. + +When adding a semantic view, Superset asks the provider to look up its name with +the submitted configuration before saving it. If lookup fails or returns no view, +Superset reports that the view may not exist or the semantic layer may be +unreachable, and does not add it. Other valid views in the same request can still Review Comment: The Add Semantic View dialog replaces 422 responses with a generic toast and shows only names on partial success, so users never see this reason. Limit this claim to the API response. ```suggestion the API reports that the view may not exist or the semantic layer may be unreachable, and does not add it. Other valid views in the same request can still ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
