codeant-ai-for-open-source[bot] commented on code in PR #45379:
URL: https://github.com/apache/superset/pull/45379#discussion_r4297746183
##########
superset-websocket/src/index.ts:
##########
@@ -222,12 +223,18 @@ export const buildRedisOpts = (baseConfig: RedisConfig)
=> {
redisOpts.password = baseConfig.password;
}
- if (baseConfig.ssl) {
- redisOpts.tls = buildTlsOptions(baseConfig);
- // ioredis ignores `tls` for the Sentinel-resolved master (connecting in
- // plaintext) unless this flag is set.
- if (redisOpts.sentinels) {
- redisOpts.enableTLSForSentinelMode = true;
+ if (baseConfig.ssl || baseConfig.sentinelSsl) {
Review Comment:
**Suggestion:** Outside Sentinel mode, `sentinelSsl` should be ignored, but
this builds TLS options and reads PEM files; a missing file can abort startup
even though TLS is unused.
**Assessment:** ๐ด `Critical` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Incorrect
condition logic`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=35b180cd37f74e7ba0292634d825a97a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=35b180cd37f74e7ba0292634d825a97a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-websocket/src/index.ts
**Line:** 226:226
**Comment:**
*Incorrect Condition Logic: Outside Sentinel mode, `sentinelSsl` should
be ignored, but this builds TLS options and reads PEM files; a missing file can
abort startup even though TLS is unused.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45379&comment_hash=3ad1a75a016bfbbfd9387506238ebc5f460a369a0029852dec6faedc9b1b57e7&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45379&comment_hash=3ad1a75a016bfbbfd9387506238ebc5f460a369a0029852dec6faedc9b1b57e7&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
