sadpandajoe commented on code in PR #45379:
URL: https://github.com/apache/superset/pull/45379#discussion_r4299404078
##########
superset-websocket/spec/index.test.ts:
##########
@@ -361,6 +362,24 @@ describe('server', () => {
// Without this flag ioredis connects to the master in plaintext.
expect(opts.enableTLSForSentinelMode).toBe(true);
});
+ test('it enables TLS for the sentinel nodes with sentinelSsl', () => {
Review Comment:
Both new Sentinel TLS tests set `ssl: true`, so nothing pins the
plaintext-master / TLS-sentinels case (`ssl: false`, `sentinelSsl: true`),
which is the main reason to have an independent flag. If a later refactor nests
the `sentinelTLS` assignment back under `if (baseConfig.ssl)`, every test here
still passes while TLS-only-sentinel deployments silently connect to the
sentinels in plaintext. Should this add a case with `ssl: false, sentinelSsl:
true` asserting `opts.sentinelTLS` is set and `opts.tls` and
`enableTLSForSentinelMode` are absent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
