codeant-ai-for-open-source[bot] commented on code in PR #45392:
URL: https://github.com/apache/superset/pull/45392#discussion_r4298444826
##########
superset-frontend/src/core/chat/ChatProvider.ts:
##########
@@ -190,10 +221,52 @@ class ChatProvider {
return this.resizePanelEmitter.subscribe;
}
+ /**
+ * Registers a single client-side tool โ mirrors commands.ts's
+ * registerCommand exactly: keyed by the tool's own `name` (fully-qualified,
+ * author-chosen โ nothing prefixes or validates it here, same as a
+ * `Command.id`), warns and overwrites on a duplicate name, and the
+ * returned Disposable removes it by name unconditionally on dispose.
+ *
+ * Registering after registerChat() is safe โ nothing here depends on call
+ * order. (An earlier version of this method warned about that ordering,
+ * back when ChatPanel snapshotted `chat.getTools()` once at mount via
+ * `useMemo(..., [])`; the actual fix was moving that snapshot to send-time
+ * in ChatPanel itself, which made the order genuinely not matter rather
+ * than just warning about it.)
+ */
+ public registerClientTool(tool: ClientTool): Disposable {
+ const { name } = tool;
+ if (this.clientTools.has(name)) {
+ logging.warn(
+ `[Superset] Client tool "${name}" is already registered. ` +
+ 'Overwriting the existing tool.',
+ );
+ }
+ this.clientTools.set(name, tool);
+ return new Disposable(() => {
+ this.clientTools.delete(name);
Review Comment:
**Suggestion:** Disposing an older registration after a duplicate-name
overwrite deletes the newer tool too, because cleanup removes the entry by name
unconditionally.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Stale reference`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b66588803918495a963b90395355261f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b66588803918495a963b90395355261f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/core/chat/ChatProvider.ts
**Line:** 248:248
**Comment:**
*Stale Reference: Disposing an older registration after a
duplicate-name overwrite deletes the newer tool too, because cleanup removes
the entry by name unconditionally.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45392&comment_hash=1785cd961856b7e6a5f3bb05182d103870708594ada3ddc391b285952e8eb586&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45392&comment_hash=1785cd961856b7e6a5f3bb05182d103870708594ada3ddc391b285952e8eb586&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
