codeant-ai-for-open-source[bot] commented on code in PR #45410:
URL: https://github.com/apache/superset/pull/45410#discussion_r4301781594
##########
superset/charts/client_processing.py:
##########
@@ -1237,6 +1250,20 @@ def label_of(name: str) -> str:
# left untouched, matching the browser.
for column in df.columns:
config = config_by_label.get(column) or {}
+
+ # Mirror the Table plugin's first formatter branch
+ # (``if (isTime || config.d3TimeFormat)`` in ``transformProps.ts``):
+ # an explicit per-column ``d3TimeFormat`` formats a temporal column and
+ # takes precedence over number formatting. Scoped to datetime columns
+ # with an explicit format; the bare ``isTime`` fallback,
+ # ``tableTimestampFormat`` default, SMART_DATE granularity, and string
+ # temporal columns are intentionally left to a follow-up, since they
+ # need a full server-side d3-time-format port rather than ``strftime``.
+ time_format = config.get("d3TimeFormat")
+ if time_format and pd.api.types.is_datetime64_any_dtype(df[column]):
+ format_time_column(df, column, time_format)
Review Comment:
**Suggestion:** `smart_date` is a valid adaptive-format option, but this
passes it to `strftime`, so every datetime cell becomes the literal
`smart_date` instead of a date.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ba8feec9f0474f798b27773d9ccf8d41&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ba8feec9f0474f798b27773d9ccf8d41&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/charts/client_processing.py
**Line:** 1262:1264
**Comment:**
*Api Mismatch: `smart_date` is a valid adaptive-format option, but this
passes it to `strftime`, so every datetime cell becomes the literal
`smart_date` instead of a date.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45410&comment_hash=9735c96d93146ff67ffd774a99ca0816c8e3fc281b616195437e0fae65cc6cd3&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45410&comment_hash=9735c96d93146ff67ffd774a99ca0816c8e3fc281b616195437e0fae65cc6cd3&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
