SEPURI-SAI-KRISHNA commented on PR #45410:
URL: https://github.com/apache/superset/pull/45410#issuecomment-6236616987
Good catch, this was a real defect. `smart_date` is the first entry in
`D3_TIME_FORMAT_OPTIONS` and `transformProps.ts` has a dedicated branch for it,
so a column config can legitimately carry it, and `strftime("smart_date")`
returns the literal string for every row.
Fixed in the follow-up commit: the branch now only runs for a
`strftime`-style format, so `smart_date` and any other alias falls through
untouched instead of being written into the cells. Added
`test_table_leaves_adaptive_time_format_alone` to cover it.
Rendering adaptive formatting server side still needs a real d3-time-format
port, which is out of scope here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
