codeant-ai-for-open-source[bot] commented on code in PR #45421:
URL: https://github.com/apache/superset/pull/45421#discussion_r4302923515
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/mergeCustomEChartOptions.ts:
##########
@@ -67,6 +68,20 @@ export function mergeCustomEChartOptions<T extends
EChartsCoreOption>(
baseValue as EChartsCoreOption,
customValue as CustomEChartOptions,
);
+ } else if (
+ key === 'series' &&
+ isPlainObject(customValue) &&
+ Array.isArray(baseValue)
+ ) {
+ // Apply a single series object to every series
+ (result as PlainObject)[key] = baseValue.map(series =>
+ isPlainObject(series)
+ ? mergeCustomEChartOptions(
+ series as EChartsCoreOption,
+ customValue as CustomEChartOptions,
+ )
+ : series,
+ );
Review Comment:
**Suggestion:** When `series.name` is overridden, every generated series
gets that name. Timeseries interactions then cannot find the original
`labelMap[seriesName]`, breaking cross-filtering and drill filters.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=928484b0aec648c88a81087b15e62ee5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=928484b0aec648c88a81087b15e62ee5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/src/utils/mergeCustomEChartOptions.ts
**Line:** 77:84
**Comment:**
*Logic Error: When `series.name` is overridden, every generated series
gets that name. Timeseries interactions then cannot find the original
`labelMap[seriesName]`, breaking cross-filtering and drill filters.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45421&comment_hash=5563c57cd3ed8ea06bb5e3aba1e3d87c5a23584a242964b38a26ab2205167887&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45421&comment_hash=5563c57cd3ed8ea06bb5e3aba1e3d87c5a23584a242964b38a26ab2205167887&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
