codeant-ai-for-open-source[bot] commented on code in PR #45421:
URL: https://github.com/apache/superset/pull/45421#discussion_r4303034142
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/mergeCustomEChartOptions.ts:
##########
@@ -67,6 +68,20 @@ export function mergeCustomEChartOptions<T extends
EChartsCoreOption>(
baseValue as EChartsCoreOption,
customValue as CustomEChartOptions,
);
+ } else if (
+ key === 'series' &&
+ isPlainObject(customValue) &&
+ Array.isArray(baseValue)
+ ) {
+ // Apply a single series object to every series
+ (result as PlainObject)[key] = baseValue.map(series =>
+ isPlainObject(series)
+ ? mergeCustomEChartOptions(
+ series as EChartsCoreOption,
+ customValue as CustomEChartOptions,
+ )
+ : series,
+ );
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `e08b217`.
The shared series options now exclude `name` and `id` before being merged
into each generated series, preserving each series’ individual identity.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
