sha174n opened a new pull request, #45453:
URL: https://github.com/apache/superset/pull/45453

   ### Summary
   
   The virtual-dataset column probe validates that the SQL is a single `SELECT` 
statement, but that check runs before `SQL_QUERY_MUTATOR`, which then runs in 
`get_columns_description` right before execution. A mutator that rewrites the 
text (for example one that round-trips it through a parser) can change the 
statement count after that validation.
   
   This re-asserts the single-statement invariant on the mutated text before it 
runs, and fails open when the dialect parser cannot read the mutated text so a 
legitimate probe is never blocked.
   
   ### Testing Instructions
   
   `pytest tests/unit_tests/connectors/sqla/utils_test.py`; the full 
`connectors/sqla` suite and `tests/unit_tests/commands/dataset/refresh_test.py` 
pass.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to