codeant-ai-for-open-source[bot] commented on code in PR #45453:
URL: https://github.com/apache/superset/pull/45453#discussion_r4313165862
##########
superset/connectors/sqla/utils.py:
##########
@@ -203,6 +203,25 @@ def get_columns_description(
limit = database.get_column_description_limit_size()
query = database.apply_limit_to_sql(query, limit=limit)
mutated_query = database.mutate_sql_based_on_config(query)
+ # Callers validate the pre-mutation SQL is a single statement, but
+ # the mutator runs afterwards. Re-assert it on the mutated text so
a
+ # mutator that rewrites the query cannot turn one statement into
+ # several. Fail open when the dialect's parser cannot read the
+ # mutated text, to avoid blocking a legitimate probe.
+ try:
+ mutated_statement_count = len(
+ SQLScript(mutated_query,
engine=db_engine_spec.engine).statements
+ )
+ except SupersetParseError:
+ mutated_statement_count = 1
+ if mutated_statement_count > 1:
Review Comment:
**Suggestion:** `SQL_QUERY_MUTATOR` can replace a validated `SELECT` with
one `DELETE`; this count-only guard allows the single mutation through to
execution.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Security`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5373a758f4cd413d8fa5e78722126d54&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5373a758f4cd413d8fa5e78722126d54&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/connectors/sqla/utils.py
**Line:** 212:217
**Comment:**
*Security: `SQL_QUERY_MUTATOR` can replace a validated `SELECT` with
one `DELETE`; this count-only guard allows the single mutation through to
execution.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45453&comment_hash=745fb7799a852910ca47dd175e8840a22662a2f6a16e84c3cc498f9d56601a88&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45453&comment_hash=745fb7799a852910ca47dd175e8840a22662a2f6a16e84c3cc498f9d56601a88&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
