codeant-ai-for-open-source[bot] commented on code in PR #45456:
URL: https://github.com/apache/superset/pull/45456#discussion_r4314381670
##########
superset/charts/client_processing.py:
##########
@@ -1272,6 +1272,11 @@ def label_of(name: str) -> str:
post_processors = {
"pivot_table_v2": pivot_table_v2,
"table": table,
+ # The AG Grid table plugin's column meta block and ``formatColumnValue``
+ # are the Table plugin's, same column config keys and same rules, so a
+ # report on one is formatted by the same post-processor. The query-building
+ # side pairs the two viz types the same way.
+ "ag-grid-table": table,
Review Comment:
**Suggestion:** AG Grid formats comparison columns using the parent metric’s
config, but `table` looks up exact column labels, so suffixed comparison
metrics remain raw in report output.
**Assessment:** 🟠 `Major` · 🔁 `Occurrence: Sometimes` · 🏷️ `Incomplete
implementation`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c68845bd992c4729843b2b3aef9650a8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c68845bd992c4729843b2b3aef9650a8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/charts/client_processing.py
**Line:** 1279:1279
**Comment:**
*Incomplete Implementation: AG Grid formats comparison columns using
the parent metric’s config, but `table` looks up exact column labels, so
suffixed comparison metrics remain raw in report output.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45456&comment_hash=d0b1c15f930dcb1db140f9a2bee3270ded2c1fd86e97ddd7dd22878229d6fbb2&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45456&comment_hash=d0b1c15f930dcb1db140f9a2bee3270ded2c1fd86e97ddd7dd22878229d6fbb2&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
