SEPURI-SAI-KRISHNA commented on code in PR #45456:
URL: https://github.com/apache/superset/pull/45456#discussion_r4361776927
##########
superset/charts/client_processing.py:
##########
@@ -1272,6 +1272,11 @@ def label_of(name: str) -> str:
post_processors = {
"pivot_table_v2": pivot_table_v2,
"table": table,
+ # The AG Grid table plugin's column meta block and ``formatColumnValue``
+ # are the Table plugin's, same column config keys and same rules, so a
+ # report on one is formatted by the same post-processor. The query-building
+ # side pairs the two viz types the same way.
+ "ag-grid-table": table,
Review Comment:
Correct, and `table` has the same gap: `SUM(x)__1 week ago` is not a key in
`column_config` or the saved formats, so it stays raw in both. This PR takes AG
Grid from no formatting to the Table plugin's level and does not close that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
