mikebridge opened a new pull request, #45476: URL: https://github.com/apache/superset/pull/45476
### SUMMARY TL;DR: Make archiving easier to understand and recovery easier to find. Background: archived charts, dashboards and datasets can be recovered from Recently Archived. The confirmation text directed users to a menu that some owners cannot see, and the archive page defaulted to Charts regardless of the item they had just archived. Changes: - Remove the menu-specific direction without changing permissions. Confirmation dialogs and single-item success messages link directly to the matching archive collection, including on subpath deployments. - Support `?type=chart`, `dashboard` and `dataset`, falling back to a permitted type for invalid or inaccessible selections. Preserve the collection when sorting and filtering. - Make disabled chart/dashboard card Archive actions visibly and semantically disabled, with permission tooltips and no click action. - Isolate object names in archive titles so bidirectional names do not reorder surrounding punctuation. - Hide dataset dependency warnings when both counts are zero. For datasets with dependencies, describe the archive impact using actual counts. Preserve permanent-delete behavior when soft delete is off. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: menu-specific directions, wrong initial collection, active-looking disabled actions, unisolated RTL names, and zero-count deletion warnings in Archive dialogs. After: direct collection links, disabled button semantics, isolated names, and archive-specific dependency warnings. Automated DOM coverage is included; no browser screenshots were captured. ### TESTING INSTRUCTIONS With `SOFT_DELETE` enabled: 1. Archive a chart, dashboard and dataset; follow the confirmation/toast links and verify the matching collection. Repeat beneath an application URL prefix. 2. Visit Recently Archived with invalid and inaccessible `type` values; verify fallback to a permitted collection. Change sorting and verify the collection stays selected. 3. As a user unable to edit a card, check the disabled Archive action and its tooltip; clicking must not open a dialog. 4. Archive an item with an RTL name and an ordinary LTR name; check title punctuation. 5. Archive unused and used datasets; check warning counts and wording. Repeat with soft delete disabled to check permanent-delete behavior. Validation: 175 tests passed across ten focused Jest suites; an additional list/card caller run passed 56 tests across four suites (overlapping coverage). Standard changed-file pre-commit hooks, including frontend type checking, passed after syncing generated declarations. Source-resolved TypeScript and the translation-catalog drift check also passed. CI remains authoritative for build and browser coverage. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Required feature flags: `SOFT_DELETE` - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Introduces new feature or API - [ ] Removes existing feature or API Updated documentation and translation catalog entries accompany the changed confirmation and dependency wording. No permission, menu-registration, retention, or deletion-request changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
