mikebridge commented on code in PR #45476:
URL: https://github.com/apache/superset/pull/45476#discussion_r4328638211
##########
superset-frontend/src/components/ListView/utils.ts:
##########
@@ -347,8 +347,8 @@ export function useListViewState<D extends object = any>({
const method =
typeof query.pageIndex !== 'undefined' &&
queryParams.pageIndex !== query.pageIndex
- ? 'push'
- : 'replace';
+ ? 'pushIn'
+ : 'replaceIn';
Review Comment:
Fixed in 268062a498. Back and Forward now restore both the filters and page
before fetching. Added regression tests for filtering from a later page and
same-page history, including range filters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
