sadpandajoe opened a new issue, #45502: URL: https://github.com/apache/superset/issues/45502
## Problem Both required checks (unit-tests-required, playwright-tests-required) are red on master. Python-Unit has 14 failures + 2 errors in the semantic layer, MCP, compatible-datasource and dashboard datasets tests (first red: https://github.com/apache/superset/actions/runs/39316150460). The Playwright "Semantic View Tests" step fails in `semantic-view-dashboard.spec.ts` (:135, :163) because `POST /api/v1/semantic_view/` returns 422 (first red: https://github.com/apache/superset/actions/runs/39315915676). ## Root cause Two merge-order breaks from #45251 (8e6e91e4d), whose branch predates #44454, #45103 and #45360. 1. `SemanticView.implementation` became a plain `@property` (`superset/semantic_layers/models.py:443-444`), so tests that assign `view.implementation = ...` or `view.__dict__['implementation']` fail or are ignored. 2. `SemanticLayer.from_configuration` now takes `cache_token`/`context`/`credentials` keyword args, always passed by `superset/semantic_layers/execution.py:277-282`. The E2E stub provider still has the one-arg signature (`tests/e2e_extensions/semantic_stub/dist/backend/src/superset_e2e_semantic_stub/__init__.py:239`), so binding raises TypeError, which `superset/commands/semantic_layer/create.py:128-147` turns into a 422. ## Steps to reproduce 1. On master (d36febc96e) run `pytest -q tests/unit_tests/semantic_layers/models_test.py tests/unit_tests/datasource/test_compatible_api.py tests/unit_tests/mcp_service/semantic_layer/tool/test_list_metrics.py tests/unit_tests/mcp_service/chart/tool/test_get_chart_data.py tests/unit_tests/semantic_layers/e2e_stub_extension_test.py tests/unit_tests/dashboards/datasets_test.py`: 14 failed, 2 errors. 2. Run with `SUPERSET_CONFIG=tests.integration_tests.superset_test_config_semantic`, create a stub semantic layer, and POST `/api/v1/semantic_view/` for view `orders`: 422. (Found via automated investigation — [Agor](https://agor.live/).) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
