Aleem89 commented on PR #45505: URL: https://github.com/apache/superset/pull/45505#issuecomment-6280563000
@sfirke wanted to get your thoughts on this. Here's a closer look at how the glyphs compare to the old markers. Same chart and same hover on 6.1 vs this branch, with five time shifts turned on so every symbol shows up: <img width="1584" height="320" alt="tooltip-symbols-6 1-vs-fix" src="https://github.com/user-attachments/assets/93b7883a-0435-4c1a-83a9-f7a46d09838a"; /> Two things don't survive the switch to text glyphs: - the pin (4 weeks ago) is now a plain dot - the rounded square and the square (2 and 3 weeks ago) both become ■ The others match pretty closely, just a bit smaller. There's a way to get most of that back without touching the sanitizer: draw the markers with `border` instead of width/height, which the allowlist already permits. That gives us the pin and the rounded square again, and only the diamond would stay a glyph since it needs `transform`. Should I go ahead and try the above to get the pin and rounded square back on this PR, or leave it as is to keep the fix small for the RC? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
