Aleem89 commented on PR #45505: URL: https://github.com/apache/superset/pull/45505#issuecomment-6283946344
Pushed the border-drawn version. Same chart and hover on 6.1, the first version of this PR, and now: <img width="1410" height="460" alt="tooltip-symbols-6 1-vs-glyphs-vs-borders" src="https://github.com/user-attachments/assets/1ad9c87b-0175-454a-85df-72ef71055c7d"; /> Circle, square, rounded square and pin are now drawn with `border` on an empty span, so they're real shapes again at the same size as before (the pin is a touch bigger so the tail reads). The triangle is borders too, lifted with a small em-based offset so it sits level with the text. The diamond stays a glyph since it needs `transform`, sized and spaced to line up with the others. The only difference left from 6.1 is the pin's tail pointing bottom-right instead of straight down, which would also need `transform`. Sanitizer untouched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
