Re: [PR] fix(echarts): keep value labels on small non-stacked bars and stack totals [superset]

Tue, 20 Oct 2026 11:06:06 -0700 


codeant-ai-for-open-source[bot] commented on code in PR #45529:
URL: https://github.com/apache/superset/pull/45529#discussion_r4328385122


##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts:
##########
@@ -592,10 +611,10 @@ export function transformSeries(
   }
 
   const isAutoBarLabel =
-    plotType === 'bar' && valueLabelPosition === BarValueLabelPosition.Auto;
+    plotType === 'bar' && barValueLabelPosition === BarValueLabelPosition.Auto;
   const isInsideBarLabel =
     plotType === 'bar' &&
-    valueLabelPosition !== BarValueLabelPosition.OutsideEnd;
+    barValueLabelPosition !== BarValueLabelPosition.OutsideEnd;

Review Comment:
   **Suggestion:** An explicit inside `labelPosition` still wins later, but 
this marks the total as outside and applies `theme.colorText`; ECharts skips 
fill-based contrast, making some stack-total labels unreadable.
   
   **Assessment:** ๐ŸŸ  `Major` ยท ๐Ÿ” `Occurrence: Rarely` ยท ๐Ÿท๏ธ `Incorrect condition 
logic`
   
   [![Use CodeAnt 
Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
 [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d395e06b568142409aef5c174df692c3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d395e06b568142409aef5c174df692c3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent ๐Ÿค– </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** 
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
   **Line:** 615:617
   **Comment:**
        *Incorrect Condition Logic: An explicit inside `labelPosition` still 
wins later, but this marks the total as outside and applies `theme.colorText`; 
ECharts skips fill-based contrast, making some stack-total labels unreadable.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45529&comment_hash=333fb74e902c5f878d94ac574813173d56e80a18bf230796e0a6e29bee7a557c&reaction=like'>๐Ÿ‘</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45529&comment_hash=333fb74e902c5f878d94ac574813173d56e80a18bf230796e0a6e29bee7a557c&reaction=dislike'>๐Ÿ‘Ž</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to