mikebridge opened a new pull request, #45534:
URL: https://github.com/apache/superset/pull/45534
## SUMMARY
Semantic views do not support SQL WHERE/HAVING extras. The regular chart
query validation already rejects them; this change applies the same guidance to
direct mapper validation, mapping and execution.
Invalid clauses are rejected rather than forwarded or silently discarded.
Empty clauses and structured semantic filters keep their existing behavior.
## BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Backend-only change; no UI screenshots. Direct mapper calls with SQL extras
previously produced ADHOC filters; they instead return the existing
unsupported-expression guidance.
## TESTING INSTRUCTIONS
Run:
```bash
python -m pytest tests/unit_tests/semantic_layers \
tests/unit_tests/queries/query_object_test.py -q
```
Regression cases cover WHERE, HAVING, both clauses,
mapping/validation/execution, and the separate group-limit filter path.
Execution asserts no query dispatch. The tests fail against the previous mapper
implementation; the focused suite passes with the change.
## ADDITIONAL INFORMATION
- No schema migration, feature-flag or configuration change.
- Ordinary SQL-dataset queries are unchanged.
- Provider-specific ADHOC behavior is outside this change.
- No new endpoint or response shape.
- [ ] Has associated issue:
- [x] Required feature flags: `SEMANTIC_LAYERS` for external semantic views
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
