codeant-ai-for-open-source[bot] commented on code in PR #45530:
URL: https://github.com/apache/superset/pull/45530#discussion_r4330307772
##########
superset/daos/dashboard.py:
##########
@@ -323,6 +323,94 @@ def reconcile_position_json(positions: object,
dashboard_id: int | None = None)
)
+def _remap_copy_chart_ids(values: list[Any], key_map: dict[str, int]) ->
list[int]:
+ """Drop omitted chart references and use clone IDs when applicable."""
+ new_id: int | None
+ return [
+ new_id for value in values if (new_id := key_map.get(str(value))) is
not None
Review Comment:
**Suggestion:** A valid whole-number float ID such as `12.0` becomes
`"12.0"` and misses the `"12"` map key, silently dropping that chart setting
during the copy.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Type error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=84486fbe21eb4c239edddf8770f9cc0a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=84486fbe21eb4c239edddf8770f9cc0a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/daos/dashboard.py
**Line:** 330:330
**Comment:**
*Type Error: A valid whole-number float ID such as `12.0` becomes
`"12.0"` and misses the `"12"` map key, silently dropping that chart setting
during the copy.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45530&comment_hash=fa324120edc3cdbb2f8952057e9f324cfd2b1686a48855dfec0ae4b76a54544d&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45530&comment_hash=fa324120edc3cdbb2f8952057e9f324cfd2b1686a48855dfec0ae4b76a54544d&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
