fitzee commented on code in PR #45530: URL: https://github.com/apache/superset/pull/45530#discussion_r4330811081
########## docs/docs/using-superset/version-history.mdx: ########## @@ -307,6 +307,17 @@ title, CSS, metadata, and layout applied over it — the copy endpoint accepts only those fields, so properties such as description, slug, certification, and theme come from the dashboard as it stands today, not from the version. +The new dashboard's settings come from the selected version's metadata. Settings Review Comment: Nit: the paragraph just above (lines 304-308, unchanged) now contradicts this one. It still says a new dashboard "is a copy of the *live* dashboard with the version's title, CSS, metadata, and layout applied over it". Its last clause is also wrong, before and after this PR: "description, slug, certification, and theme come from the dashboard as it stands today". `DashboardCopySchema` accepts only `dashboard_title`, `css`, `json_metadata` and `duplicate_slices`, and `copy_dashboard` sets nothing else apart from editors/viewers. So the copy's description, slug, certification and theme are empty or default, not inherited. Suggest folding the two paragraphs into one: title, CSS, settings and layout come from the version. Description, slug, certification and theme are not copied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
