SBIN2010 commented on code in PR #45458:
URL: https://github.com/apache/superset/pull/45458#discussion_r4330224491
##########
superset-frontend/plugins/plugin-chart-echarts/src/Candlestick/constants.ts:
##########
@@ -24,11 +24,13 @@ import {
import { defaultXAxis } from '../defaults';
import { CandlestickSeriesStyle, EchartsCandlestickFormData } from './types';
+// Bare 'Open'/'Close' would share a msgid with the dialog actions of the same
+// name, so the labels carry their own strings to be translated as prices.
Review Comment:
In `constants.ts`, it is noted that the standalone "Open" and "Close" share
an `msgid` with dialog actions. A collision occurs only with "Close". The terms
`t('Open')`, `t('High')`, and `t('Low')` are not used anywhere else; they were
renamed to ensure consistent labeling across both tooltips and controls. This
should be stated explicitly; otherwise, the next person reading the code might
go looking for a conflict that doesn't actually exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
