schizophrenicmaniac commented on code in PR #45458:
URL: https://github.com/apache/superset/pull/45458#discussion_r4330437552
##########
superset-frontend/plugins/plugin-chart-echarts/src/Candlestick/constants.ts:
##########
@@ -24,11 +24,13 @@ import {
import { defaultXAxis } from '../defaults';
import { CandlestickSeriesStyle, EchartsCandlestickFormData } from './types';
+// Bare 'Open'/'Close' would share a msgid with the dialog actions of the same
+// name, so the labels carry their own strings to be translated as prices.
Review Comment:
Good point, the old comment overstated it. I've reworded it: only 'Close'
collides with the dialog action, and 'Open', 'High' and 'Low' were renamed just
to keep the tooltip and control labels consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
