hughhhh opened a new pull request, #45556: URL: https://github.com/apache/superset/pull/45556
### SUMMARY In the dataset editor, `CollectionTable`'s `onFieldsetChange` wrote back the collection captured in its closure. Fieldset edits commit on a debounce and each expanded row renders its own `Fieldset`, so when two rows were edited within one debounce window the later commit wrote a stale snapshot and silently dropped the other row's edit. This affects every columns/metrics table in the editor. `onFieldsetChange` now uses functional state updaters, like the component's other mutators, and replaces the edited row in place so order is preserved. The unused `changeCollection` helper is removed. Split out of #43870 at a reviewer's request; it is independent of partition filter mapping. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A (state bug, no visual change). ### TESTING INSTRUCTIONS - `npx jest src/components/Datasource/components/CollectionTable` — new test "a delayed fieldset commit does not revert another row's edit" fails without the fix; "a fieldset commit preserves the collection order" guards ordering. - Manual: open a dataset's Edit modal → Columns, expand two rows, edit a field in each quickly, save; both edits persist. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
