codeant-ai-for-open-source[bot] commented on code in PR #45556:
URL: https://github.com/apache/superset/pull/45556#discussion_r4334474814
##########
superset-frontend/src/components/Datasource/components/CollectionTable/index.tsx:
##########
@@ -292,15 +259,31 @@ export default function CRUDCollection({
const onFieldsetChange = useCallback(
(item: CollectionItem) => {
- changeCollection(
- {
- ...collection,
- [item.id]: item,
- },
- collectionArray,
- );
+ // Functional updaters: fieldset edits commit on a debounce and each
+ // expanded row has its own Fieldset, so a captured collection may be
+ // stale by the time it lands and would revert another row's edit.
+ setCollection(prevCollection => ({
+ ...prevCollection,
+ [item.id]: item,
+ }));
+
+ setCollectionArray(prevCollectionArray => {
+ const newCollectionArray = prevCollectionArray.some(
+ existing => existing.id === item.id,
+ )
+ ? prevCollectionArray.map(existing =>
+ existing.id === item.id ? item : existing,
+ )
+ : [...prevCollectionArray, item];
Review Comment:
**Suggestion:** When an expanded row with a pending debounced
TextAreaControl edit is deleted, unmount flushes its callback; this branch
appends the missing row again and undoes the deletion.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Stale reference`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=68edd48491764ead82404973118f56de&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=68edd48491764ead82404973118f56de&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/components/Datasource/components/CollectionTable/index.tsx
**Line:** 271:277
**Comment:**
*Stale Reference: When an expanded row with a pending debounced
TextAreaControl edit is deleted, unmount flushes its callback; this branch
appends the missing row again and undoes the deletion.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45556&comment_hash=c7ab793db28add1d5f4496dffbbce135aea2866110c41bad56a7a9d08c05cbc3&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45556&comment_hash=c7ab793db28add1d5f4496dffbbce135aea2866110c41bad56a7a9d08c05cbc3&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
