Aitema-gmbh commented on PR #39235: URL: https://github.com/apache/superset/pull/39235#issuecomment-6312744790
Thanks for the careful read, @rusackas — all three points were real, and they're fixed in the rebased commit: - **Compounding `em`s:** `SectionName` now inherits its size from `TooltipContent` instead of applying the `fontSizeSM` reduction a second time, so section headers land at `fontSizeSM` as intended. - **`line-height: 1` clipping risk:** the SQL Lab run button now uses `line-height: 1.2` (still unitless, so it scales with the user's text size, but with headroom for ascenders/descenders). - **Fixed-px icon size:** the "Exit fullscreen" icon in `SliceHeaderControls` now sizes relative to its surrounding text (`fontSizeXL / fontSize` in `em`) rather than a pixel value. On the `sharded-jest-tests (5)` / `(7)` pattern: yes, it was a pattern, but not from this batch. All four of those CI runs (#39233, #39234, #39235, #39242) date from 30 June, against the `master` of that day, where `SavedQueryList › "+ Query" router-relative path` and the `TablePreview` metadata tests were failing on their own (reproducible on bare `master` at the time, see the notes in those PRs). I've rebased this PR onto today's `master` as a single commit so CI runs fresh; the two touched test suites pass locally (111/111) and `oxfmt` is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
