codeant-ai-for-open-source[bot] commented on code in PR #39235:
URL: https://github.com/apache/superset/pull/39235#discussion_r4335222346
##########
superset-frontend/src/dashboard/components/CustomizationsBadge/index.tsx:
##########
@@ -83,7 +83,7 @@ const StyledTag = styled(Tag)`
vertical-align: middle;
color: ${theme.colorTextSecondary};
margin-right: ${theme.sizeUnit * 0.5}px;
- font-size: 12px;
+ font-size: ${theme.fontSizeSM}px;
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `71c84fa`.
The icon font size now uses a theme-relative `em` value instead of a fixed
pixel size, so it scales with its surrounding text.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
##########
superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx:
##########
@@ -79,7 +79,7 @@ const onClick = (
const StyledButton = styled.span`
button {
- line-height: 13px;
+ line-height: 1;
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `71c84fa`.
The button’s line-height is now `1.2` instead of `1`, providing more
vertical space for the label.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
##########
superset-frontend/src/dashboard/components/CustomizationsBadge/index.tsx:
##########
@@ -120,14 +120,14 @@ const TooltipContent = styled.div`
max-width: 300px;
overflow-x: hidden;
color: ${theme.colorText};
- font-size: ${theme.fontSizeSM}px;
+ font-size: ${theme.fontSizeSM / theme.fontSize}em;
`}
`;
const SectionName = styled.span`
${({ theme }) => `
font-weight: ${theme.fontWeightStrong};
- font-size: ${theme.fontSizeSM}px;
+ font-size: ${theme.fontSizeSM / theme.fontSize}em;
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `71c84fa`.
`SectionName` no longer sets its own font size, so it inherits the size from
`TooltipContent` without applying a second reduction.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
