Aitema-gmbh commented on PR #39234: URL: https://github.com/apache/superset/pull/39234#issuecomment-6312766320
Thanks for reading the gate so carefully, @rusackas — that's exactly the intent: the nudge only fires when the caller supplied neither `colorPrimary` nor `colorLink`, so an operator's explicit brand color is never silently rewritten, and the 4.5:1 guarantee applies to the default theme. Whether that tradeoff should be configurable is a fair product question we're happy to follow up on if you'd like, but we think brand fidelity is the safer default for existing deployments. On the two jest shards: those failures were from the 30 June CI run against that day's `master`, where `SavedQueryList` and `TablePreview` were failing on their own (reproducible on bare `master` at the time, same shards on #39233 and #39235). I've rebased this PR onto today's `master` as a single commit so CI runs fresh. The merge only touched the imports and two comment blocks in `Theme.tsx`; the WCAG tests pass locally and `oxfmt` is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
