Aitema-gmbh commented on PR #39233: URL: https://github.com/apache/superset/pull/39233#issuecomment-6312808173
Thanks @rusackas — both points were right, and they're addressed in the rebased commit: - **Dead code:** correct, `ImportModal/index.tsx` renders `ImportErrorAlert`, not the `ErrorAlert.tsx` sitting next to it. Looking at the live path, `ImportErrorAlert` already goes through the shared `ErrorAlert` with `errorType="Import Error"` rendered as a visible heading plus an icon, so the import flow already carries a non-color cue. I've dropped the edit to the unused file rather than duplicate the prefix there. (The unused `ImportModal/ErrorAlert.tsx` looks like a leftover that could go in a separate cleanup.) - **Accessible name:** the status icon now passes `lastStateConfig.label` as its `aria-label`, so assistive tech announces "Report failed" / "Alert triggered, notification sent" etc. instead of the icon's file name. Two tests cover it. One caveat: for custom (non-antd) icons `BaseIcon` puts its generated label on the wrapper span, so the animated Running icon keeps "running" as its name until `BaseIcon` itself is adjusted (#39230 touches that component). - **Shards (5)/(7):** same story as on #39234/#39235: that was the 30 June run against that day's `master`. Rebased onto today's `master` as a single commit so CI runs fresh; the four touched suites pass locally and `oxfmt` is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
