sadpandajoe commented on code in PR #39232:
URL: https://github.com/apache/superset/pull/39232#discussion_r4335581144
##########
superset-frontend/src/features/users/UserListModal.tsx:
##########
@@ -139,6 +141,7 @@ function UserListModal({
>
<Input
name="username"
+ autoComplete="username"
Review Comment:
This modal creates and edits other people's accounts, but `given-name`,
`family-name`, `username` and `email` tell the browser these fields hold the
signed-in person's own details. An admin using browser autofill while adding a
colleague could end up with their own name, username or email filled into the
new user's record. 1.3.5 targets fields about the user filling in the form, so
would `autoComplete="off"` be a better fit for these four fields here, keeping
the personal tokens on `UserInfoModal` and the login/register pages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
