sadpandajoe commented on code in PR #39232:
URL: https://github.com/apache/superset/pull/39232#discussion_r4346004983
##########
superset-frontend/src/features/userInfo/UserInfoModal.tsx:
##########
@@ -118,6 +123,7 @@ function UserInfoModal({
>
<Input.Password
name="password"
+ autoComplete="new-password"
Review Comment:
The sibling `current_password` field a few lines above (the "Current
password" input in this same reset form) still has no `autoComplete`, while the
new and confirm fields now declare `new-password`. A password manager or
assistive tech then has to guess which of the three password inputs is the
existing credential, so this form is only partly covered for 1.3.5. Would
`autoComplete="current-password"` on that input fit here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
