sadpandajoe commented on code in PR #45522:
URL: https://github.com/apache/superset/pull/45522#discussion_r4338925639
##########
superset/initialization/__init__.py:
##########
@@ -667,6 +671,12 @@ def init_extensions(self) -> None:
return
for extension in extensions.values():
+ # Before the backend entrypoint runs: a page is declared in the
+ # manifest, so it does not depend on extension code importing
+ # cleanly, and a frontend-only extension contributes pages too.
+ register_extension_pages(self.superset_app, extension.manifest)
Review Comment:
The new unconditional `register_extension_pages(self.superset_app, ...)`
call breaks the existing
`test_init_extensions_logs_exception_instead_of_printing`
(`tests/unit_tests/test_init_extensions_logging.py`): its initializer has no
`superset_app`, so it raises `AttributeError` before reaching its assertion and
`unit-tests (current)` fails. Can that fixture set `superset_app`, or stub
these helpers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
