codeant-ai-for-open-source[bot] commented on code in PR #45522:
URL: https://github.com/apache/superset/pull/45522#discussion_r4389050792
##########
superset/initialization/__init__.py:
##########
@@ -667,6 +671,12 @@ def init_extensions(self) -> None:
return
for extension in extensions.values():
+ # Before the backend entrypoint runs: a page is declared in the
+ # manifest, so it does not depend on extension code importing
+ # cleanly, and a frontend-only extension contributes pages too.
+ register_extension_pages(self.superset_app, extension.manifest)
Review Comment:
**Suggestion:** This check runs before `eager_import(backend.entrypoint)`;
if the entrypoint registers a route under the page path, the overlap goes
undetected and both routes are installed.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6ab82a579520493b89e22a690a34d873&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6ab82a579520493b89e22a690a34d873&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/initialization/__init__.py
**Line:** 677:677
**Comment:**
*Api Mismatch: This check runs before
`eager_import(backend.entrypoint)`; if the entrypoint registers a route under
the page path, the overlap goes undetected and both routes are installed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45522&comment_hash=81522f73217a88a160a8ebdeb52fe372b68de170305b3cd078fcf805f468386d&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45522&comment_hash=81522f73217a88a160a8ebdeb52fe372b68de170305b3cd078fcf805f468386d&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
