aminghadersohi commented on PR #45571: URL: https://github.com/apache/superset/pull/45571#issuecomment-6320999253
Acceptance run against a local docker-compose-light stack (examples `cleaned_sales_data`, `order_date` 2003-01 to 2005-05), head frontend built from the branch, compared with the merge base f9a0d8af49 in the same env. - A Sunburst created through the MCP chart tools with a monthly grain: MCP returns 180 rows; Explore now shows Time Grain = Month and queries the same 180 rows (merge base: no control, 600 daily rows). - Explore: Month 180 rows, Year 21 rows; categorical and adhoc hierarchies hide the control and send no grain; removing the temporal level drops the grain. - Dashboard Time Grain filter Month → Year regroups the MCP chart, the Explore chart and a chart saved without a grain (29 → 3). A Sunburst saved before this change keeps raw levels until re-saved in Explore (same as the merge base); I added that to the known limitations. - Charts saved without a grain send byte-identical Explore queries at head and merge base (5 charts); dashboard queries differ only by dropping an inert `time_grain_sqla` on non-temporal charts, same rows. - Embedded guest: all charts load, categorical cross-filters apply, and grained references to columns outside the hierarchy (and forged SQL) are rejected with 403. - The server-side form-data builder matches the Explore query for 9/9 form_data captured from the browser; MCP row counts match Explore. Found and fixed in 18f0389292c0d7e7b2d6cb49d139c083d0c1b36b and 98eb82e32322e2854cff3cc24e8ee7b48d5db27c: drill to detail on a monthly segment returned 0 rows because the detail filter compared `order_date` to the bucket start without the grain. It now carries the applied grain (dashboard grain first), as the Timeseries chart does, and returns the month's 158 rows. Test: `test/Sunburst/EchartsSunburst.test.tsx` (two of its three tests fail without the change). Not changed here, also present on the merge base: a cross-filter from a temporal ring sends the formatted label (`order_date == 'October'`), so the other charts fail with an invalid timestamp error, and month labels in `smart_date` show only the month name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
