aminghadersohi commented on PR #45571: URL: https://github.com/apache/superset/pull/45571#issuecomment-6346727544
@rebenitez1802, I applied the review-body changes in 80118e754d0f087124087fdfc59ebae3e4e2a8e5, with adhoc drill transport in e3492ea8b6b73bb03479637bb7e421c314bcd54b: - Drill design: both Sunburst actions use raw equality plus grain, and `Sunburst/timeGrain.ts` is the shared query/render subject resolver, including dashboard Time Column overrides. Regression test: `tests/unit_tests/models/test_sunburst_drill_hours_offset.py::test_sunburst_factory_drill_preserves_bucket_with_time_range` fails before and passes after. - Two temporal semantic levels: each explicitly grained reference is validated/grouped independently. Regression test: `tests/unit_tests/semantic_layers/mapper_test.py::test_sunburst_two_explicit_temporal_levels` reproduces the two-level failure and unsupported second-level grain case before, and passes after. Semantic drill grain variants are covered too. - Engine-specific grains: the drill payload preserves every grain rather than calculating frontend bounds. Regression test: `superset-frontend/plugins/plugin-chart-echarts/test/Sunburst/EchartsSunburst.test.tsx` — `drills retain engine-supported grain %s without calculating bounds` fails for the six supplied grain cases before and passes here. - Unrelated diff: the translation source-location line is removed. `tests/unit_tests/security/manager_test.py` is byte-identical to the PR merge base; the existing Sunburst guest regression is retained in `tests/unit_tests/security/test_sunburst_guest.py::test_raise_for_access_guest_user_ok_grained_sunburst`. Remaining: landing order and merging the overlapping files with https://github.com/apache/superset/pull/45598 are not completed here. I did not rebase or edit that branch. This branch supplies the equality-plus-grain drill contract and shared helper for the sibling worker to consume with a normal merge after the first PR lands. Siblings checked: - superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/EchartsSunburst.tsx — fixed in 80118e754d0f087124087fdfc59ebae3e4e2a8e5 - superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/timeGrain.ts — fixed in 80118e754d0f087124087fdfc59ebae3e4e2a8e5 - superset/semantic_layers/mapper.py — fixed in 80118e754d0f087124087fdfc59ebae3e4e2a8e5 - superset/common/query_context_factory.py — fixed in 80118e754d0f087124087fdfc59ebae3e4e2a8e5 - superset/models/helpers.py — fixed in 80118e754d0f087124087fdfc59ebae3e4e2a8e5 - superset-frontend/plugins/plugin-chart-echarts/src/utils/xAxisDrillByFilter.ts — not affected: Sunburst drills bypass frontend range calculation; unchanged Timeseries/cross-filter range consumers are separate contracts - tests/unit_tests/security/manager_test.py — not affected: no remaining PR diff after relocating Sunburst coverage Final head: `8cc881ab51c29c79d574d7b254933fa7babd3019`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
