codeant-ai-for-open-source[bot] commented on code in PR #45580:
URL: https://github.com/apache/superset/pull/45580#discussion_r4340231590
##########
superset-frontend/packages/superset-ui-core/src/components/DropdownContainer/DropdownContainer.tsx:
##########
@@ -283,15 +283,28 @@ export const DropdownContainer = forwardRef(
useLayoutEffect(() => {
if (popoverVisible) {
+ let resizeObserver: ResizeObserver | undefined;
// Measures scroll height after rendering the elements
- setTimeout(() => {
- if (targetRef.current) {
+ const timeout = setTimeout(() => {
+ const target = targetRef.current;
+ if (target) {
// We only set overflow when there's enough space to display
// Select's popovers because they are restrained by the overflow
property.
- setShowOverflow(targetRef.current.scrollHeight > MAX_HEIGHT);
+ const updateShowOverflow = () =>
+ setShowOverflow(target.scrollHeight > MAX_HEIGHT);
+ updateShowOverflow();
+ // The content can grow while the popover is open, e.g. when a
+ // collapsible section inside it is expanded, so keep measuring.
+ resizeObserver = new ResizeObserver(updateShowOverflow);
+ resizeObserver.observe(target);
Review Comment:
**Suggestion:** With a fixed-height `dropdownStyle`, expanding overflowing
children changes `scrollHeight` without resizing `target`; the observer never
reruns, leaving the popover overflow visible.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Logic error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=53445e8d1da24b1dbe341524283383b6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=53445e8d1da24b1dbe341524283383b6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/components/DropdownContainer/DropdownContainer.tsx
**Line:** 299:299
**Comment:**
*Logic Error: With a fixed-height `dropdownStyle`, expanding
overflowing children changes `scrollHeight` without resizing `target`; the
observer never reruns, leaving the popover overflow visible.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45580&comment_hash=14f3a1f08b79a8f460f15a27dcf77db0c3ed186f76cdba195b9b4607a288c9ec&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45580&comment_hash=14f3a1f08b79a8f460f15a27dcf77db0c3ed186f76cdba195b9b4607a288c9ec&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
