rusackas commented on code in PR #44878:
URL: https://github.com/apache/superset/pull/44878#discussion_r4343272248
##########
superset-frontend/src/explore/components/ExploreViewContainer/index.tsx:
##########
@@ -844,6 +870,18 @@ function ExploreViewContainer(props:
ExploreViewContainerProps) {
}
}, [props.controls, props.ownState]);
+ useEffect(
+ () => () => {
Review Comment:
Good catch @sadpandajoe. Added a test for both axes that adds a title,
unmounts inside the 250 ms window, advances timers, and asserts no programmatic
margin write happens. I could not run jest in this checkout, so CI is its first
run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
