rusackas opened a new pull request, #45608: URL: https://github.com/apache/superset/pull/45608
### SUMMARY Follow-up to the finding on #45601: the `cache-restore` / `cache-save` helpers from the `cached-dependencies` submodule call a retired cache API, and the repo has no cache entries for anything they manage. `build-instrumented-assets` relied on them, so the "Build javascript packages" step has been doing a full instrumented webpack build in each of the four Playwright jobs on every run, 55 to 70 seconds apiece. This restores `superset/static/assets` with a plain `actions/cache` step (same pin the bundle-size job uses) keyed on the frontend sources, the lockfile and `.nvmrc`, before `npm ci` in both Playwright jobs. The bash function keeps its existing manifest check and skips the webpack build on a hit; on a miss it builds as before and the post-job save stores the result. The two dead helper calls come out of `bashlib.sh`, along with the commented-out npm ones. Backend-only PRs hit the cache master builds; frontend PRs miss once per push and hit on re-runs. The first run on this PR is the miss; I'll re-run for the hit and post both numbers. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS Compare the "Build javascript packages" step on this PR's re-run against master (55 to 70 s). The Playwright suites themselves verify the restored assets. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
