rusackas commented on PR #45608: URL: https://github.com/apache/superset/pull/45608#issuecomment-6335324028
Timing numbers from this branch's E2E runs, now that the cache key is right. Before (and on `master`), the "Build instrumented assets" step rebuilds in all four Playwright jobs every run since the old submodule cache helpers have been silently dead. On this PR's first run (a cold miss) that step was 51s, 52s, 66s and 66s across the four jobs. On the re-run against the warm cache it was 0s in all four, with the restore step itself taking 3 to 5s. So roughly a minute per job, four jobs per run, and it should hit on every push that doesn't touch frontend source or the lockfile. One gotcha I hit along the way, for anyone curious: webpack emits `service-worker.js` one directory above `superset/static/assets`, so the first version of this only cached the assets folder and the GAQ jobs failed on a 404 for the service worker. Both paths are in the cache now and all four jobs pass on the hit path, GAQ included. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
