sfirke commented on issue #45632:
URL: https://github.com/apache/superset/issues/45632#issuecomment-6343386547
In the initial code review, @kgabryje wrote:
-----------
4. Secondary search inputs are deliberately hidden — worth confirming the UX
call
Filters/index.tsx:93-96, 174-175 only renders the first search filter. I see
this is intentional (commit 04c947ec12, comment "one search box per page"), but
the effect across admin pages is:
Users: lost Last Name, Email, Username search (only First Name remains)
RLS: lost Group Key search (only Name)
Groups: lost Label, Description (only Name)
Worth flagging in the PR description so reviewers don't miss it, and worth
checking with whoever owns admin workflows. If we want to keep "one search box
per page" as a principle, consider exposing the hidden search fields as
pills-with-input-on-open so the workflow isn't dropped.
-----------
Yes, if we are doing "one search box per page" here then I would expect the
search to target multiple fields. It seems wrong to me that, for the sake of
simplifying a sprawling UI, we are making it so that user search only searches
first name, undocumented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
