aminghadersohi commented on PR #45598: URL: https://github.com/apache/superset/pull/45598#issuecomment-6348608455
@rebenitez1802 One more item for Remaining in https://github.com/apache/superset/pull/45598#issuecomment-6348210986, found by an independent check of that reply at head 62cef72cee285fa71d1b5d43fe44a69ea48422ff: on a dataset with a valid non-UTC timezone (America/Los_Angeles) and an Hours offset of 1, a grained `==` or `IN` filter on a one-row day bucket returns 0 rows and the matching `NOT IN` returns 2 rows instead of 1, with and without the SQL shift. The displayed bucket labels are converted to the local timezone, but the grained comparison value is not converted back to UTC and is not compared against a similarly converted grouping expression. This is pre-existing on master: the merge-base `superset/models/helpers.py` reproduces the same six failures. It is out of scope for this PR, whose gate only inverts the Hours offset when the timezone is absent or invalid, and it will get its own PR after this one lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
